Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading node-auth0 from v3 to v4 #953

Merged
merged 102 commits into from
Oct 21, 2024
Merged

Upgrading node-auth0 from v3 to v4 #953

merged 102 commits into from
Oct 21, 2024

Conversation

kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Sep 6, 2024 •
edited
Loading

🔧 Changes

Upgrading node-auth0 from v3 to v4. This is a necessary upgrade because all new Auth0 features and dependency patches are getting released on v4 now.

This was originally attempted in #887 but had a few changes that need to be reviewed. This should require a major version bump for Deploy CLI due to changes in v4.

📓 Done:

  • Create migration doc.
  • Sync with the master branch new fixs and features ahead in the timeline.

📚 References
Original PR: #887

Related:

🔬 Testing

Deploy CLI commands like import, export

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@kushalshit27 kushalshit27 mentioned this pull request Sep 6, 2024
Closed
2 tasks
willvedd
willvedd reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good start but a few suggestions and questions.

src/context/index.ts Outdated Show resolved Hide resolved
src/tools/auth0/client.ts Outdated Show resolved Hide resolved
src/tools/auth0/handlers/actions.ts Outdated Show resolved Hide resolved
src/tools/auth0/handlers/actions.ts Outdated Show resolved Hide resolved
src/tools/auth0/handlers/actions.ts Outdated Show resolved Hide resolved
src/tools/auth0/handlers/emailProvider.ts Outdated Show resolved Hide resolved
src/tools/auth0/handlers/hooks.ts Show resolved Hide resolved
src/tools/auth0/handlers/logStreams.ts Outdated Show resolved Hide resolved
src/tools/auth0/handlers/roles.ts Outdated Show resolved Hide resolved
src/tools/auth0/handlers/tenant.ts Outdated Show resolved Hide resolved
willvedd
willvedd reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor pieces of feedback. But this is good, starting to reach the finish!

@auth0 auth0 deleted a comment from semgrepcode-auth0 bot Sep 25, 2024
frederikprijck and others added 22 commits September 26, 2024 10:27
@frederikprijck @kushalshit27
Upgrade auth0 to v4
82187a8
@frederikprijck @kushalshit27
Update tests
d776f80
@frederikprijck @kushalshit27
Ensure e2e tests run against a live tenant
1afff46
@frederikprijck @kushalshit27
Fix linter
0369f0e
@frederikprijck @kushalshit27
fix tests
dc33301
@adamjmcgrath @kushalshit27
fix package-lock
d804c76
@adamjmcgrath @kushalshit27
fix e2e tests
9259c23
@adamjmcgrath @kushalshit27
Ignore missing client overload error for now
f568838
@adamjmcgrath @kushalshit27
fix unit test
395bb85
@kushalshit27
update auth0: 4.7.0
34d584c
@kushalshit27
update readme
f209c95
@kushalshit27
update readme
4e7e024
@kushalshit27
undo readme updates
87e0b0b
@kushalshit27
remove old param parameter from processChanges
d26aa04
@kushalshit27
DELETE email provider deprecation
b5efb17
@kushalshit27
refactor email template updatOrCreate reasponse
917f824
@kushalshit27
fix context test for invalid client secret
aa45ea7
@kushalshit27
emailProvider test fix
4042d27
@kushalshit27
attackProtection test fix: should update attack protection settings
9d10814
@kushalshit27
auth0 version update 4.7.0 ->4.8.0
24d6296
@kushalshit27
apply formatting to guardianFactorProviders.ts
c2f1a54
@kushalshit27
paginate through all roles for getAll roles
bdccebd
nandan-bhat
nandan-bhat previously approved these changes Oct 14, 2024
View reviewed changes
@kushalshit27 kushalshit27 dismissed stale reviews from nandan-bhat and willvedd via 13de5cc October 14, 2024 07:28
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.56446% with 73 lines in your changes missing coverage. Please review.

Project coverage is 80.49%. Comparing base (f50106f) to head (262b582).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/tools/auth0/handlers/scimHandler.ts 60.00% 14 Missing and 4 partials ⚠️
...rc/tools/auth0/handlers/guardianFactorProviders.ts 27.77% 6 Missing and 7 partials ⚠️
...rc/tools/auth0/handlers/guardianFactorTemplates.ts 40.00% 4 Missing and 2 partials ⚠️
src/context/index.ts 20.00% 4 Missing ⚠️
src/tools/auth0/handlers/actions.ts 71.42% 1 Missing and 3 partials ⚠️
src/tools/auth0/handlers/default.ts 42.85% 2 Missing and 2 partials ⚠️
src/tools/auth0/handlers/prompts.ts 75.00% 3 Missing and 1 partial ⚠️
src/tools/auth0/handlers/roles.ts 80.00% 3 Missing and 1 partial ⚠️
src/tools/auth0/handlers/triggers.ts 20.00% 4 Missing ⚠️
src/tools/auth0/handlers/databases.ts 72.72% 1 Missing and 2 partials ⚠️
... and 5 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
- Coverage   84.28%   80.49%   -3.79%     
==========================================
  Files         116      113       -3     
  Lines        3805     3825      +20     
  Branches      746      761      +15     
==========================================
- Hits         3207     3079     -128     
- Misses        331      460     +129     
- Partials      267      286      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalshit27 kushalshit27 merged commit 65ab9d2 into master Oct 21, 2024
10 checks passed
@kushalshit27 kushalshit27 deleted the migration-to-v4 branch October 21, 2024 09:26
@iwakrur iwakrur mentioned this pull request Nov 20, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandan-bhat nandan-bhat nandan-bhat approved these changes

@willvedd willvedd Awaiting requested review from willvedd

@developerkunal developerkunal Awaiting requested review from developerkunal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kushalshit27 @codecov-commenter @willvedd @developerkunal @nandan-bhat @frederikprijck @adamjmcgrath @BavoLuysterborg